AST: Rename VarDecl::getType() to VarDecl::getTypeInContext() #67739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
ktoso,
hborla,
xedin,
kavon,
adrian-prantl,
ahoppen,
bnbarham,
rintaro,
hamishknight,
zoecarver,
hyp and
egorzhdan
as code owners
|
#67737 |
hamishknight
approved these changes
Aug 4, 2023
Comment on lines
149
to
+152
| llvm::SmallVector<const ParamDecl *, 8> silParamMapping; | ||
| for (auto param : *fd->getParameters()) { | ||
| if (auto *tuple = | ||
| param->getType()->getDesugaredType()->getAs<TupleType>()) { | ||
| param->getInterfaceType()->getAs<TupleType>()) { |
There was a problem hiding this comment.
Is it expected this won't handle the following? e.g
protocol P {
associatedtype X
}
extension P where X == (Int, Int) {
func foo(_ x: X) {}
}There was a problem hiding this comment.
I guess this is a problem with anything that looks at the interface type of a parameter. I think type resolution should just map generic parameters to concrete types in this case since it's a systemic issue throughout the compiler.
However this particular check looks like some kind of hack already?
There was a problem hiding this comment.
Yeah that makes sense, just wanted to make sure the change was intentional
| @@ -2268,7 +2268,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> { | |||
| // NOTE: We do this here instead of TypeCheckAttr since types are not | |||
| // completely type checked at that point. | |||
| if (auto attr = VD->getAttrs().getAttribute<NoImplicitCopyAttr>()) { | |||
| if (auto *nom = VD->getType()->getCanonicalType()->getNominalOrBoundGenericNominal()) { | |||
| if (auto *nom = VD->getInterfaceType()->getNominalOrBoundGenericNominal()) { | |||
Comment on lines
3967
to
+3968
| if (auto attr = param->getAttrs().getAttribute<NoImplicitCopyAttr>()) { | ||
| if (auto *nom = param->getType()->getCanonicalType()->getNominalOrBoundGenericNominal()) { | ||
| if (auto *nom = param->getInterfaceType()->getNominalOrBoundGenericNominal()) { |
This is a futile attempt to discourage future use of getType() by giving it a "scary" name. We want people to use getInterfaceType() like with the other decl kinds.
slavapestov
force-pushed
the
var-decl-type-in-context
branch
from
2b6b663 to
9ebb5f2
Compare
|
swiftlang/llvm-project#7150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a futile attempt to discourage future use of getType() by giving it a "scary" name.
We want people to use getInterfaceType() like with the other decl kinds.