[DebugInfo] Require 64-bit arch for debug info fragment LIT tests #67699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests depend on the target layout, and there were issues reported for Android armv7 (see swiftlang#66744) and watchOS (swiftlang#66879) targets.
|
@swift-ci please test |
finagolfin
reviewed
Aug 3, 2023
test/IRGen/debug_fragment_merge.sil
Outdated
| @@ -3,7 +3,7 @@ | |||
| // Checking the below on 32 bit architectures would be cumbersome: each | |||
| // fragment is 32 bits long, which changes the number of checks as well as the | |||
| // arithmethic on the bounds of each fragment. | |||
| // UNSUPPORTED: OS=watchos | |||
| // REQUIRES: CPU=arm64 || CPU=x86_64 | |||
There was a problem hiding this comment.
I see several tests that also check for arm64e, not needed here?
There was a problem hiding this comment.
Good idea, added arm64e targets as well.
|
@swift-ci please test |
|
@swift-ci Please test |
finagolfin
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests depend on the target layout, and there were issues reported for Android armv7 (see #66744) and watchOS (#66879) targets.