[Linux][Backtracing] Fix a couple of backtracer issues. #67429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux specifically, it was possible for it to return `nil` to signal the end of the unwind, then subsequently return non-`nil` again. That violates the expectations of the code layered above it, and can cause an "Index out of range" error to occur. rdar://112534548
The code that looks up line numbers wasn't respecting the end-sequence flag, so it could "find" a line number between the end of one sequence and the beginning of another. That was wrong. rdar://112595022
|
@swift-ci Please smoke test |
mikeash
approved these changes
Jul 20, 2023
tomerd
approved these changes
Jul 20, 2023
|
shell we also cherry pick to 5.9 once merged? |
ktoso
approved these changes
Jul 20, 2023
:-) I've already done that: #67430. Just needs a branch manager to approve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
FramePointerUnwinderso it always returnsnilafter the it first stops iteration.Fix line number processing so that we don't erroneously match regions between the end of one sequence and the start of the next.
rdar://112534548, rdar://112595022