Enable test: discarding task group making sure we deinit confidently #67417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-reenable-async_taskgroup_discarding
branch
from
d703a7a to
bcf9d1b
Compare
tomerd
reviewed
Jul 19, 2023
tomerd
approved these changes
Jul 19, 2023
ktoso
added
test suite
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #67392 / rdar://110474311 we believe this type of failure:
to be caused by the process exiting before the deinits complete running. We add a latch to make sure the deinits got to run before we exit the app
Resolves rdar://110025115 and re-enables
Concurrency/Runtime/async_taskgroup_discarding.swift