Skip to content

[5.9] [SymbolGraphGen] allow cursor symbol graphs from function params #67270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2023
Merged

[5.9] [SymbolGraphGen] allow cursor symbol graphs from function params #67270

merged 3 commits into from
Jul 13, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Cherry-pick of #67267

  • Explanation: Updates SymbolGraphGen to support ParamDecl symbols, to support function and closure parameters.
  • Scope: Allows SourceKit to generate cursor-info symbol graphs for these symbols.
  • Issue: rdar://105516823
  • Risk: Low. The change is targeted to symbols that ordinarily wouldn't appear in whole-module symbol graphs, and only allows more symbols to have single-decl symbol graphs via SourceKit.
  • Testing: A test has been added to ensure the expected behavior.
  • Reviewer: @bnbarham

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner July 12, 2023 21:03
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit 5550394 into release/5.9 Jul 13, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.9/param-sgf branch July 13, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuietMisdreavus @bnbarham