[Runtime][IRGen] Sign type context descriptor pointers. #67168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeash
requested review from
tshortli,
hborla,
slavapestov and
xedin
as code owners
mikeash
force-pushed
the
ptrauth-struct-context-descriptors
branch
from
85b1508 to
69662f3
Compare
|
@swift-ci please test |
mikeash
force-pushed
the
ptrauth-struct-context-descriptors
branch
2 times, most recently
from
1b5abc2 to
1a5ff19
Compare
|
@swift-ci please test |
Ensure that context descriptor pointers are signed in the runtime by putting the ptrauth_struct attribute on the types. We use the new __builtin_ptrauth_struct_key/disc to conditionally apply ptrauth_struct to TrailingObjects based on the signing of the base type, so that pointers to TrailingObjects get signed when used with a context descriptor pointer. We add new runtime entrypoints that take signed pointers where appropriate, and have the compiler emit calls to the new entrypoints when targeting a sufficiently new OS. rdar://111480914
mikeash
force-pushed
the
ptrauth-struct-context-descriptors
branch
from
1a5ff19 to
fe7e13b
Compare
|
@swift-ci please test |
|
could you run the preset that corresponds to https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-device-non_executable/ It could be that some tests on iphoneos-arm64e might need updating |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
From the failures I got before, I think PR testing covers iOS ARM64e non-executable tests, but I'll run that preset too just to make sure. |
|
@swift-ci please test windows platform |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that context descriptor pointers are signed in the runtime by putting the ptrauth_struct attribute on the types.
We use the new __builtin_ptrauth_struct_key/disc to conditionally apply ptrauth_struct to TrailingObjects based on the signing of the base type, so that pointers to TrailingObjects get signed when used with a context descriptor pointer.
We add new runtime entrypoints that take signed pointers where appropriate, and have the compiler emit calls to the new entrypoints when targeting a sufficiently new OS.
rdar://111480914