Skip to content

[Docs][Android] Fix minimal Android API level #66775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

CmST0us
Copy link

@CmST0us CmST0us commented Jun 20, 2023

When compile swift using NDK, I meet this problem.

/home/eki/Project/swift-project/swift/stdlib/public/runtime/CrashHandlerLinux.cpp:665:12: error: use of undeclared identifier 'process_vm_readv'
    return process_vm_readv(memserver_pid, &local, 1, &remote, 1, 0);
           ^
1 error generated.

I found that this function should use android api level greater than 23

#if __ANDROID_API__ >= 23
ssize_t process_vm_readv(pid_t __pid, const struct iovec* __local_iov, unsigned long __local_iov_count, const struct iovec* __remote_iov, unsigned long __remote_iov_count, unsigned long __flags) __INTRODUCED_IN(23);

@CmST0us
Copy link
Author

CmST0us commented Jun 21, 2023

relate #63708

@finagolfin
Copy link
Member

@CmST0us
Copy link
Author

CmST0us commented Jun 22, 2023

@swift-ci Please smoke test

@CmST0us
Copy link
Author

CmST0us commented Jun 22, 2023

Thanks, I noticed this last week and notified the guy who runs the community Android CI, let's see what he says.

got😀, I modify the api level to 23 in build-preset.ini, pls review?

@finagolfin
Copy link
Member

I'm not sure what he'll say, let's see.

@finagolfin
Copy link
Member

I fixed this in #67478 instead, should keep working with API 21 now. Try it out and close this if it works for you.

@CmST0us
Copy link
Author

CmST0us commented Aug 7, 2023

It works, thanks!

@CmST0us CmST0us closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants