[cxx-interop] Make CxxShim header and modulemap arch-independent #66765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves `libcxxshim.modulemap`, `libcxxshim.h` and `libcxxstdlibshim.h` from `*.xctoolchain/usr/lib/swift/macosx/arm64e` to `*.xctoolchain/usr/lib/swift/macosx` to simplify distribution. rdar://110788977
Contributor
Author
|
@swift-ci please smoke test |
zoecarver
approved these changes
Jun 20, 2023
Contributor
zoecarver
left a comment
zoecarver
left a comment
There was a problem hiding this comment.
LGTM. I don't know too much about this code, though. I think you're the code owner for this part of the compiler :)
egorzhdan
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Jun 22, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765 rdar://110788977
This was referenced Jun 22, 2023
egorzhdan
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Jun 22, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765 rdar://110788977
compnerd
pushed a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Jun 22, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765 rdar://110788977
compnerd
added a commit
to compnerd/swift-installer-scripts
that referenced
this pull request
Jul 27, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765 rdar://110788977
compnerd
added a commit
to compnerd/swift-installer-scripts
that referenced
this pull request
Jul 27, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765 rdar://110788977 Fixes: swiftlang/swift#67462
compnerd
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Jul 27, 2023
This adjusts the Windows installation logic after the changes in swiftlang/swift#66765 rdar://110788977 Fixes: swiftlang/swift#67462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
libcxxshim.modulemap,libcxxshim.handlibcxxstdlibshim.hfrom*.xctoolchain/usr/lib/swift/macosx/arm64eto*.xctoolchain/usr/lib/swift/macosxto simplify distribution.rdar://110788977