🍒[5.9][Distributed] Harden typechecker against completely empty DAS types #66697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When implementing a distributed actor system protocol and the implementation is "completely empty" we may run into null pointers when trying to look up ad hoc requirements.
Solution: The safe thing to do here is to bail out from lookups when lookups for ad-hoc requirements are made on null types.
Risk: Low, only adds nullchecks
Review by: @DougGregor
Testing: CI testing
Original PR: #66695
Radar: rdar://110708278
resolves #66548