[5.9] A few SILGen fixes for variadic generics #66684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SILGen expects this of values before we enter general routines. Fixes rdar://109911655
variadic-tuple results. There are three parts to this. First, fix the emission of indirect result parameters to do a proper abstraction-pattern-aware traversal of tuple patterns. There was a FIXME here and everything. Second, fix the computation of substituted abstraction patterns to properly handle vanishing tuples. The previous code was recursively destructuring tuples, but only when it saw a tuple as the substituted type, which of course breaks on vanishing tuples. Finally, fix the emission of returns into vanishing tuple patterns by allowing the code to not produce a TupleInitialization when the tuple pattern vanishes. We should always get a singleton element initializer in this case. Fixes rdar://109843932, plus a closely-related test case for vanishing tuples that I added myself.
I don't like that this method exists, and I'd like to rip it out in favor of expecting an opaque lowering, but I'm worried about doing that this late in 5.9. Fixes rdar://107290521
|
@swift-ci Please test |
jckarter
approved these changes
Jun 15, 2023
hborla
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a handful of bugs relating to code (SIL) emission for variadic generics, mostly relating to tuple types. Bugs are described in the individual commits.
Scope: changes are mostly isolated to paths specific to variadic generics; there are some exceptions, but they just make the code follow well-established code patterns
Risk: Low
Reviewed by: Holly Borla, Joe Groff
Fixes rdar://107290521, rdar://109843932, rdar://109911655, and #66594.
5.9 version of #66658 and #66683.