Skip to content

Sema: Diagnose @backDeployed on functions with opaque result types #66673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

The compiler does not yet implement support for back deploying opaque result types.

Resolves rdar://110806234

@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli tshortli requested review from xymus, beccadax, elsh and artemcm June 15, 2023 16:36
Sometimes it's useful to be more lenient when type checking swiftinterfaces
since restrictions that could be dropped in the future will manifest in
resilient libraries being incompatible with older compilers otherwise.
@tshortli tshortli force-pushed the diagnose-back-deployed-opaque-result-types branch from 86acc34 to cdf4bc3 Compare June 15, 2023 18:17
@tshortli
Copy link
Contributor Author

In anticipation of this restriction being a source of condfails, I've updated the fix to limit the diagnostic to a warning in swiftinterfaces.

The compiler does not yet implement support for back deploying opaque result
types.

Resolves rdar://110806234
@tshortli tshortli force-pushed the diagnose-back-deployed-opaque-result-types branch from cdf4bc3 to c8f4dab Compare June 15, 2023 23:08
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli tshortli merged commit 79616c4 into swiftlang:main Jun 16, 2023
@tshortli tshortli deleted the diagnose-back-deployed-opaque-result-types branch June 16, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants