Skip to content

don't use Clang modules in the "only re-export public symbols" check #66671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuietMisdreavus
Copy link
Contributor

Cherry-pick of #66610

  • Explanation: When an underlying Clang module is present, the [-symbol-graph]-minimum-access-level flags for SymbolGraphGen are overridden by the "export-import only public symbols" check. This PR changes the latter check to require that symbols and export-imported modules come from the same compiler for the symbol to be considered re-exported.
  • Scope: Affects users who want to view internal symbols in a symbol graph but also have Clang code in their project.
  • Issue: rdar://110399757
  • Risk: Low. The change in behavior should only affect underlying Clang modules; other behavior around export-imports should be unaffected, as is normal compilation.
  • Testing: A test has been added to ensure that [-symbol-graph]-minimum-access-level continues to work as expected in the presence of an underlying Clang module. Existing tests continue to pass.
  • Reviewer: @daniel-grumberg

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner June 15, 2023 16:21
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit b3d1207 into release/5.9 Jun 16, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.9/clang-minimum-access-level branch June 16, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants