Skip to content

[5.9][Frontend] Ignore adjacent swiftmodule in compiler host modules #66633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

bnbarham
Copy link
Contributor

  • Explanation: lib/swift/host contains modules/libraries that are built by the host compiler. Their .swiftmodule will never be able to be read and thus they need to be ignored entirely if they exist (which could happen in eg. a local build).
  • Scope: Module loading
  • Risk: Very low. Builds from the swiftinterface rather than swiftmodule, which is all that's distributed anyway. This only impacts local build environments.
  • Original PR: [Frontend] Ignore adjacent swiftmodule in compiler host modules #66576

`lib/swift/host` contains modules/libraries that are built by the host
compiler. Their `.swiftmodule` will never be able to be read, ignore
them entirely.

(cherry picked from commit ee3a47b)
@bnbarham bnbarham requested a review from a team as a code owner June 14, 2023 16:47
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham merged commit e0f169c into swiftlang:release/5.9 Jun 15, 2023
@bnbarham bnbarham deleted the cherry-ignore-host-modules branch June 15, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants