Skip to content

[CanonicalizeOSSALifetime] Gardening: Tweaked comments. #66583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[CanonicalizeOSSALifetime] Gardening: Tweaked comments. #66583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/SILOptimizer/Utils/CanonicalizeOSSALifetime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ void CanonicalizeOSSALifetime::findOriginalBoundary(
/// These are the "original" live blocks (originalLiveBlocks).
/// [Color these blocks green.]
/// - From within that collection, collect the blocks which contain a _final_
/// consuming, non-destroy use, and their successors.
/// consuming, non-destroy use, and their iterative successors.
/// These are the "consumed" blocks (consumedAtExitBlocks).
/// [Color these blocks red.]
/// - Extend liveness down to the boundary between originalLiveBlocks and
Expand Down Expand Up @@ -569,8 +569,11 @@ void CanonicalizeOSSALifetime::extendUnconsumedLiveness(
}
}

// Second, collect the blocks which occur after a _final_ consuming use.
// Second, collect the blocks which contain a _final_ consuming use and their
// iterative successors within the originalLiveBlocks.
BasicBlockSet consumedAtExitBlocks(currentDef->getFunction());
// The subset of consumedAtExitBlocks which do not contain a _final_ consuming
// use, i.e. the subset that is dead.
StackList<SILBasicBlock *> consumedAtEntryBlocks(currentDef->getFunction());
{
// Start the forward walk from blocks which contain _final_ non-destroy
Expand All @@ -596,8 +599,8 @@ void CanonicalizeOSSALifetime::extendUnconsumedLiveness(
}
}

// Third, find the blocks on the boundary between the originally-live blocks
// and the originally-live-but-consumed blocks. Extend liveness "to the end"
// Third, find the blocks on the boundary between the originalLiveBlocks
// blocks and the consumedAtEntryBlocks blocks. Extend liveness "to the end"
// of these blocks.
for (auto *block : consumedAtEntryBlocks) {
for (auto *predecessor : block->getPredecessorBlocks()) {
Expand Down