Skip to content

[utils] Show the string value of swift::Identifier in LLDB #66272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

egorzhdan
Copy link
Contributor

This adds a straightforward LLDB pretty printer for swift::Identifier which prints its string value.

@egorzhdan egorzhdan requested review from kastiglione and gottesmm June 1, 2023 14:12
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@kastiglione kastiglione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this, I have two comments.

This adds a straightforward LLDB pretty printer for `swift::Identifier` which prints its string value.
@egorzhdan egorzhdan force-pushed the egorzhdan/lldb-pretty-printer-identifier branch from 455ffda to 4269c02 Compare June 2, 2023 14:56
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan merged commit a5f0dbc into main Jun 2, 2023
@egorzhdan egorzhdan deleted the egorzhdan/lldb-pretty-printer-identifier branch June 2, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants