[Serialization] Add flag to force unsafe recovery from some xref failures #66186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures Intro a deserialization mode controlled by the flag `-experimental-force-workaround-broken-modules` to attempt unsafe recovery from deserialization failures caused by project issues. The one issue handled at this time is when a type moves from one module to another. With this new mode the compiler may be able to pick a matching type in a different module. This is risky to use, but may help in a pinch for a client to fix and issue in a library over which they have no control.
|
@swift-ci Please smoke test |
bnbarham
reviewed
May 26, 2023
Comment on lines
1965
to
1971
| llvm::handleAllErrors(std::move(error), | ||
| [&](const ModularizationError &modularError) { | ||
| modularError.diagnose(this, DiagnosticBehavior::Remark); | ||
| }); | ||
| getContext().Diags.diagnose(getSourceLoc(), | ||
| diag::modularization_issue_worked_around, | ||
| foundIn); |
There was a problem hiding this comment.
Would it be possible to make this a warning with the remark instead attached as a note?
There was a problem hiding this comment.
Good idea. I inverted both diagnostics, using the warning as the main message with the current remark as a note.
Use the `attempting forced recovery` diagnostic as main warning to which we attach other messages as notes. Also mention the flag in the diagnostic to reinforce that the flag is active.
|
@swift-ci Please smoke test |
bnbarham
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro a deserialization mode controlled by the flag
-experimental-force-workaround-broken-modulesto attempt unsafe recovery from deserialization failures caused by project issues.The one issue handled at this time is when a type moves from one module to another. With this new mode the compiler may be able to pick a matching type in a different module. This is risky to use, but may help in a pinch for a client to fix and issue in a library over which they have no control.