🍒[5.9][Distributed] Explicitly ban __owned and other specifiers we dont support #66120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please test |
|
Nice catch! CC: @jckarter |
tbkka
approved these changes
May 25, 2023
|
Thanks for review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Distributed function IRGen cannot handle ownership specifiers so we should ban them explicitly until we can handle them.
consumingis already prevented "by accident" for reasons that moveonly types cannot conform to protocols yet, and consuming cannot be used with copyable types yet; but we can then in any case until we support them in IRGen of distributed invocations.Risk: Low, just prevents code which would have crashed.
Review by: @DougGregor @drexin
Testing: CI testing
Original PR: #66119
Radar: rdar://109225190