[Build] Build libcxx on lldb ASAN/UBSAN bots #66078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael137
force-pushed
the
bugfix/lldb-asan-bots-libcxx-testing
branch
from
7893c8e to
bfc0362
Compare
|
@swift-ci test |
Michael137
force-pushed
the
bugfix/lldb-asan-bots-libcxx-testing
branch
from
bfc0362 to
5b68215
Compare
Michael137
requested review from
artemcm,
hborla,
slavapestov and
xedin
as code owners
The preset for ubsan/asan buildbots include the `buildbot_incremental_base` preset, which builds/runs tests. But the tests now require libcxx to be built since swiftlang#66018
Michael137
force-pushed
the
bugfix/lldb-asan-bots-libcxx-testing
branch
from
5b68215 to
2bf08f0
Compare
Michael137
requested review from
adrian-prantl
and removed request for
xedin,
slavapestov,
artemcm and
hborla
|
preset=buildbot_incremental,lldb_asan_ubsan |
|
preset=buildbot_incremental,lldb_asan_ubsan |
|
preset=buildbot_incremental,lldb_asan_ubsan |
|
@swift-ci test |
|
preset=buildbot_incremental,lldb_asan_ubsan |
|
preset=buildbot_incremental,lldb_asan_ubsan |
adrian-prantl
approved these changes
May 30, 2023
|
Hmm, tests on Linux fail with: Which makes sense since it's a Darwin specific preset which I ran by accident. The macOS failures are the same ones as on the buildbot right now (without my change). So I'll go ahead and merge once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preset for ubsan/asan buildbots include the
buildbot_incremental_basepreset, which builds/runstests. But the tests now require libcxx to be built
since #66018