[AST] Preserve RecursiveTypeProperties::HasTypeVariable for PlaceholderType
#65702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lderType This is a tentative fix for rdar://108947721, I haven't yet been able to reproduce the issue. Make sure we preserve the "has type variables" recursive property for placeholder types to ensure we don't do permanent allocation for any type wrapping a placeholder type that has a type variable. Otherwise, we could end up deallocating the placeholder, and having another type allocated in its place.
|
@swift-ci please smoke test |
|
preset=buildbot_osx_package @swift-ci please test with preset |
|
Hmm actually this is likely to break things too, since we use |
|
Going to just revert instead for now #65704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative fix for rdar://108947721 (and hopefully rdar://108947854), I haven't yet been able to reproduce the issue.
Make sure we preserve the "has type variables" recursive property for placeholder types to ensure we don't do permanent allocation for any type wrapping a placeholder type that has a type variable. Otherwise, we could end up deallocating the placeholder, and having another type allocated in its place.