MemoryLifetimeVerifier: be more precise with indirect function arguments. #65592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
eeckstein
force-pushed
the
fix-sil-verifier
branch
from
3cc98eb to
2e47bbf
Compare
|
@swift-ci test |
…iorFn A NFC simplification
verifier failures must be placed into memory_lifetime_failures.sil. Otherwise they won't be tested.
…nts. Optimizations can rely on alias analysis to know that an in-argument (or parts of it) is not actually read. We have to do the same in the verifier: if alias analysis says that an in-argument is not read, there is no need that the memory location is initialized. Fixes a false verifier error. rdar://106806899
eeckstein
force-pushed
the
fix-sil-verifier
branch
from
2e47bbf to
4b33b99
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizations can rely on alias analysis to know that an in-argument (or parts of it) is not actually read.
We have to do the same in the verifier: if alias analysis says that an in-argument is not read, there is no need that the memory location is initialized.
Fixes a false verifier error.
rdar://106806899
Also simplify the getMemBehaviorFn in the CalleeAnalysis (a NFC), which I discovered while working on the verifier.