Basic: add a workaround for VS2019 #65308
Conversation
When building with MSVC, we seem to be hitting a crash in the compiler. The crash seems to originate from the use of the `member_constructible` predicate being used in the `std::enable_if`. Use a local variable instead to avoid this issue. This problem is already resolved in VS2022, and hopefully we will be switching to that soon.
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
CC: @airspeedswift @DougGregor @tkremenek This is needed to repair the CI builds for 5.8 (which get triggered on backports). This is simply a syntactic workaround to prevent a crash in MSVC, NFCI. |
|
Hi @compnerd – is this a pick of a PR on main, or it this specific to this branch only, and not needed in other releases? |
|
Whenever we cherry pick something it's always important to link to the original PR if there is one (or explain why there isn't). Especially if that's where the code review happened. |
|
@airspeedswift this is not a cherry-pick. We have only hit the MSVC failure on this branch, and so I am limiting the workaround for the compiler to this branch. There is already some work to migrate to VS2022 which will obviate the need for this, but I don't think that we want to change the compilers at this point for the 5.8 release. |
|
@airspeedswift ping? We should get this resolved so that we are in a state where we could ship a 5.8 release if we needed. |
When building with MSVC, we seem to be hitting a crash in the compiler. The crash seems to originate from the use of the
member_constructiblepredicate being used in thestd::enable_if. Use a local variable instead to avoid this issue. This problem is already resolved in VS2022, and hopefully we will be switching to that soon.