🍒[5.9][Concurrency] ensure #if $MoveOnly evaluates to true and bring back moveonly Job #64666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I enabled move-only types by default, but I didn't realize that the `Feature::MoveOnly` needs to graduate into a `LANGUAGE_FEATURE` so that `EvaluateIfConfigCondition` will recognize `$MoveOnly` as being true. fixes rdar://107050387
This reverts commit abe377c. Co-authored-by: Konrad `ktoso` Malawski <konrad_malawski@apple.com>
|
@swift-ci please test |
ktoso
changed the title
Job type in the _Concurrency libJob type in the _Concurrency lib
ktoso
changed the title
Job type in the _Concurrency lib
ktoso
added
concurrency
DougGregor
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: There was a subtle issue with feature flags after I enabled move-only types by default. Turns out that the $MoveOnly feature guard wasn't always evaluating to true when the -enable-experimental-move-only isn't provided. This change now ensures that's the case so that public noncopyable types compiled in different modules are picked up correctly.
This would break any use of moveonly types in the stdlib, including the first user of it: the
JobAPI. This PR resolves this issue.Risk: Low, the feature was missing a flag and this corrects the behavior
Review by: @jckarter @DougGregor @kavon
Testing: CI testing; and have manually verified this resolved the issue that moveonly types did not work in certain builds.
Original PR: #64560
Radar: rdar://107050387