[Macros] Load '-load-plugin-library' plugins lazily #64610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
commented
Mar 24, 2023
rintaro
force-pushed
the
macros-lazy-plugin-library
branch
from
587d531 to
b6511f7
Compare
* Argument to '-load-plugin-library' now must have a filename that's
'{libprefix}{modulename}.{sharedlibraryextension}'
* Load '-load-plugin-library' plugins are now lazily loaded in
'CompilerPluginLoadRequest'
* Remove ASTContext.LoadedSymbols cache because they are cached by
'ExternalMacroDefinitionRequest' anyway
* `-load-plugin-executable` format validation is now in
'ParseSearchPathArgs'
rintaro
force-pushed
the
macros-lazy-plugin-library
branch
from
b6511f7 to
d8c8574
Compare
|
@swift-ci Please smoke test |
rintaro
commented
Mar 24, 2023
| getImpl().ExecutablePluginPaths[getIdentifier(moduleName)] = pathStr; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| void *ASTContext::getAddressOfSymbol(const char *name, | ||
| void *libraryHandleHint) { | ||
| auto lookup = getImpl().LoadedSymbols.try_emplace(name, nullptr); |
There was a problem hiding this comment.
Now that dlsym is performed only with libraryHint, so it's inlined in lib/Sema/TypeCheckMacros.cpp
bnbarham
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-load-plugin-librarynow must have a filename that's{libprefix}{modulename}.{sharedlibraryextension}-load-plugin-libraryplugins are now lazily loaded inCompilerPluginLoadRequestASTContext.LoadedSymbolscache because they are cached byExternalMacroDefinitionRequestanyway-load-plugin-executableformat validation is moved toParseSearchPathArgs