Skip to content

Add code owners for IDE-related directories #64596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add code owners for IDE-related directories #64596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@
/include/swift/DependencyScan @artemcm
/include/swift/Driver @artemcm
# TODO: /include/swift/IRGen/
/include/swift/IDE/ @ahoppen @bnbarham @rintaro
/include/swift/Index/ @bnbarham
/include/swift/Refactoring @ahoppen @bnbarham
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you’ve added test/Index. Were the indexing sources purposely omitted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just missed them. Thanks for noticing

/include/swift/Parse/ @ahoppen @bnbarham @CodaFi @DougGregor @rintaro
/include/swift/PrintAsClang @zoecarver @hyp @egorzhdan
# TODO: /include/swift/SIL/
Expand All @@ -87,6 +90,10 @@
/lib/Driver @artemcm
/lib/Frontend/ModuleInterfaceLoader.cpp @artemcm
# TODO: /lib/IRGen/
/lib/IDE/ @ahoppen @bnbarham @rintaro
/lib/IDETool/ @ahoppen @bnbarham @rintaro
/lib/Index/ @bnbarham
/lib/Refactoring/ @ahoppen @bnbarham
/lib/IRGen/*Distributed* @ktoso
/lib/Parse/ @ahoppen @bnbarham @CodaFi @DougGregor @rintaro
/lib/PrintAsClang @zoecarver @hyp @egorzhdan
Expand Down Expand Up @@ -123,6 +130,10 @@
/test/Driver/ @artemcm
/test/Generics/ @hborla @slavapestov
# TODO: /test/IRGen/
/test/IDE/ @ahoppen @bnbarham @rintaro
/test/Index/ @bnbarham
/test/refactoring/ @ahoppen @bnbarham
/test/SourceKit/ @ahoppen @bnbarham @rintaro
/test/Interop/ @zoecarver @hyp @egorzhdan
/test/Parse/ @ahoppen @bnbarham @CodaFi @DougGregor @rintaro
# TODO: /test/SIL/
Expand All @@ -141,25 +152,38 @@

# tools
# TODO: /tools
/tools/SourceKit @ahoppen @bnbarham @rintaro
/tools/swift-ide-test @ahoppen @bnbarham @rintaro
/tools/swift-refactor @ahoppen @bnbarham

# unittests
/unittests/AST/ @hborla @slavapestov @xedin
/unittests/AST/*Evaluator* @CodaFi @slavapestov
/unittests/Parse/ @ahoppen @bnbarham @CodaFi @DougGregor @rintaro
# TODO: /unittests/SIL/
/unittests/Sema/ @hborla @xedin
/unittests/SourceKit/ @ahoppen @bnbarham @rintaro
# TODO: /unittests/stdlib/

# userdocs
# TODO: /userdocs

# utils
/utils/*windows* @compnerd
/utils/update-checkout* @shahmishal
/utils/update_checkout/ @shahmishal
/utils/*windows* @compnerd
/utils/gyb_sourcekit_support/ @ahoppen @bnbarham @rintaro
/utils/sourcekit_fuzzer/ @ahoppen @bnbarham @rintaro
/utils/swift_build_support/products/earlyswiftsyntax.py @ahoppen @bnbarham
/utils/swift_build_support/products/skstresstester.py @ahoppen @bnbarham
/utils/swift_build_support/products/sourcekitlsp.py @ahoppen @bnbarham
/utils/swift_build_support/products/swiftevolve.py @ahoppen @bnbarham
/utils/swift_build_support/products/swiftformat.py @ahoppen @allevato @bnbarham
/utils/swift_build_support/products/swiftsyntax.py @ahoppen @bnbarham
/utils/update-checkout* @shahmishal
/utils/update_checkout/ @shahmishal

# validation-test
# TODO: /validation-test/IRGen/
/validation-test/IDE/ @ahoppen @bnbarham @rintaro
/validation-test/Parse/ @ahoppen @bnbarham @CodaFi @DougGregor @rintaro
# TODO: /validation-test/SIL/
# TODO: /validation-test/SILGen/
Expand Down