[Workaround][Concurrency] Mark Job as NOT moveonly until we fix moveonly use in stdlib #64536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
slavapestov,
jckarter,
kavon,
gottesmm,
DougGregor,
hborla and
tbkka
ktoso
changed the title
ktoso
changed the title
|
@swift-ci please clean smoke test |
kavon
added a commit
to kavon/swift
that referenced
this pull request
Mar 23, 2023
…ix moveonly types (swiftlang#64536)" This reverts commit abe377c.
kavon
added a commit
to kavon/swift
that referenced
this pull request
Mar 23, 2023
…ix moveonly types (swiftlang#64536)" This reverts commit abe377c.
etcwilde
pushed a commit
to etcwilde/swift
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moveonly types in stdlib, the only instance of which is
Job, are somehow broken and sometimes fail to look up like this:This can be worked around by doing a clean build and it sometimes just works.
It seems to be caused by moveonly, and not other configuration issues.
In order to get CI into a workable state until this issue is fixed, this PR removes the annotation and disables (or works-around) tests using this type.
Jobbefore shipping.