[move-only] Initial commit of debug info for noncopyable types #64475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_debuginfo. This is in preparation for wiring up debug info support for noncopyable values. Originally this flag name made sense since it was set when we performed consume operator checking. Now I am going to use it for noncopyable types as well. I think the new name uses_moveable_value_debuginfo actually describes what the flag is supposed to do, tell IRGen that the value may be moved since it needs to use moveable value debug info emission.
Just getting parsing/serialization to work. I haven't wired it up to anything.
…/debug_value, set the [moveable_value_debuginfo] flag. This still does not have the complete behavior that we want since we are not yet inserting the debug_value undef to invalidate after performing moves. NOTE: In printed SIL, I decided to make the flag implicit if we have a noncopyable type. This is just to reduce the bloat in SIL. If one needs this property for a copyable type though, it is mandatory.
I included here SIL tests and in a separate PR against lldb included lldb tests that validate as we step that the values are validated/invalidated as appropriate. rdar://106767457
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
Hmm, investigating what happened with those tests. |
|
@swift-ci please clean smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://106767457