[Macros] Add env variable option to dump exectuable plugin messagings #64407
Conversation
rintaro
changed the title
|
@swift-ci Please smoke test |
rintaro
requested review from
zoecarver,
CodaFi,
hborla,
slavapestov and
xedin
as code owners
rintaro
requested review from
bnbarham
and removed request for
xedin,
slavapestov,
CodaFi,
hborla and
zoecarver
lib/AST/PluginRegistry.cpp
Outdated
| const char *dumpMessaging = ::getenv("SWIFT_DUMP_PLUGIN_MESSAGING"); | ||
| plugin->setDumpMessaging(dumpMessaging != nullptr); |
There was a problem hiding this comment.
Not a compiler option because a plugin can be reused between multiple compiler invocations.
That's only true for sourcekit right? Could we have this as a property on the PluginRegistry? Regular compilations could use either a compilation flag or the env variable and sourcekit just the env variable?
I don't think this really matters though, so if you'd like to keep it the way it is that's fine too.
There was a problem hiding this comment.
Made a PluginRegistry's property because accessing getenv for each plugin loading is not necessary.
As for making this a compilation flag, I don't know, just let me keep it a env var.
|
preset=asan |
rintaro
force-pushed
the
macros-dump-plugin-messaging
branch
from
1d14f19 to
02ef103
Compare
|
@swift-ci Please smoke test |
Set 'SWIFT_DUMP_PLUGIN_MESSAGING' env variable to enable it.
And stop using '-dump-macro-expansions'
rintaro
force-pushed
the
macros-dump-plugin-messaging
branch
from
02ef103 to
d5b8c84
Compare
|
@swift-ci Please smoke test |
Set
SWIFT_DUMP_PLUGIN_MESSAGINGenv variable to enable it.Not a compiler option because a plugin can be reused between multiple compiler invocations.