Downgrade placeholder error to warning for swiftparser #64382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/downgrade-placeholder-error-to-warning
branch
2 times, most recently
from
7fe4513 to
8cc2d57
Compare
kimdv
requested review from
bnbarham,
CodaFi,
DougGregor,
rintaro and
zoecarver
as code owners
ahoppen
reviewed
Mar 16, 2023
kimdv
force-pushed
the
kimdv/downgrade-placeholder-error-to-warning
branch
2 times, most recently
from
d4b3dc2 to
36ddb29
Compare
|
@swift-ci Please smoke test |
kimdv
force-pushed
the
kimdv/downgrade-placeholder-error-to-warning
branch
from
36ddb29 to
41c9af8
Compare
|
@swift-ci Please smoke test |
ahoppen
reviewed
Mar 22, 2023
kimdv
force-pushed
the
kimdv/downgrade-placeholder-error-to-warning
branch
2 times, most recently
from
4989a59 to
b7735a4
Compare
|
@swift-ci Please smoke test |
kimdv
force-pushed
the
kimdv/downgrade-placeholder-error-to-warning
branch
from
b7735a4 to
cc89fbb
Compare
|
@swift-ci Please smoke test |
ahoppen
approved these changes
Mar 24, 2023
kimdv
force-pushed
the
kimdv/downgrade-placeholder-error-to-warning
branch
from
cc89fbb to
35cd77d
Compare
|
@swift-ci Please smoke test |
kimdv
force-pushed
the
kimdv/downgrade-placeholder-error-to-warning
branch
from
35cd77d to
8fb787d
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
1 similar comment
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftlang/swift-syntax#1380