[Macros] Introduce Macro AST #62071
Merged
[Macros] Introduce Macro AST #62071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had two implementations of the code that forms the macro evaluation context buffer, one in ASTGen and one in Sema. Unify them into a single place, and unify the creation of macros so we localize this arcane knowledge.
The macro signature context was a (possibly generic) struct declaration containing a typealias. We don't need the struct itself, because the typealias can be generic as well. This eliminates an extra, annoying hop through name lookup.
…Macro. Plumb the information about the owning module and supplemental signature modules through to the Macro data structure, for both built-in and plugin macros. We're resolving the given module names into module declarations, but otherwise performing no checking and not emitting any diagnostics. This information is not yet used.
|
@swift-ci please smoke test |
|
Does this have a corresponding swift-syntax PR? |
|
The swift-syntax part was swiftlang/swift-syntax#1071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an AST entity
Macroto describe macros. Create aMacroinstance for each builtin or plugin-provided macro that is used in the program, populating it with all of the information needed for semantic analysis and macro expansion. In doing so, unify the code paths for builtin and plugin-provided macros as much as we can.