[swift][TBDGen] Stop adding redundant ObjC Classes #62068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
approved these changes
Nov 11, 2022
|
@swift-ci please test |
tshortli
approved these changes
Nov 11, 2022
TBD files contain a section reserved for obj-c classes. Previously, TBDGen was adding symbols with this + normal globals with objc class prefixes. This patch removes the extra globals being added. This also accounts for this behavior for `validate-tbd-against-ir` checking. Resolves: rdar://101442087
cyndyishida
force-pushed
the
moClassesMoProblems
branch
from
cbb5bc7 to
2081d6a
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD files contain a section reserved for obj-c classes. Previously, TBDGen was adding symbols with this + normal globals with objc class prefixes. This patch removes the extra globals being added.
This also accounts for this behavior for
validate-tbd-against-irchecking.Resolves: rdar://101442087