[OpaqueValues] Handled more instructions. #61924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that it can be called on partial_apply instructions, insertAfterFullEvaluation does not name what the function does. One could imagine a function which inserted after the applies of (non-escaping) partial_applies.
nate-chandler
force-pushed
the
opaque-values/2/20221103
branch
from
7fef0c4 to
912855d
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
opaque-values/2/20221103
branch
from
912855d to
8b8e916
Compare
|
@swift-ci please smoke test |
atrick
approved these changes
Nov 4, 2022
| auto *load = builder.createLoad(cvi->getLoc(), destAddr, | ||
| LoadOwnershipQualifier::Copy); | ||
| cvi->replaceAllUsesWith(load); | ||
| pass.deleter.forceDelete(cvi); |
There was a problem hiding this comment.
what about the non-copy use case?
atrick
requested changes
Nov 4, 2022
When casting via unchecked_bitwise_cast, if the destination type is loadable, don't mark the value it produces rewritten--that value is not one that AddressLowering is tracking. Instead, replace its copy_value uses with load [copy] uses of the address the rewritten instruction produces.
The handling is the same as for value_metatype.
nate-chandler
force-pushed
the
opaque-values/2/20221103
branch
from
8b8e916 to
57352d7
Compare
|
@swift-ci please test |
atrick
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #61897 , #61917 .