[OpaqueValues] Return generic tuples directly. #61893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the API was only on FullApplySite, but it is useful to be able to insert code after a partial_apply as well.
Rather than being able to handle only to FullApplySites, it now handles PartialApplyInsts as well.
Use the CallArgRewriter to rewrite uses by partial_apply insts just as uses by apply insts, etc., are rewritten.
When branching to the exit block, flatten an @out tuple return value into its components, as is done for all other return values. In the exit block, when constructing the @out tuple to return, visit the tuple-type-tree of the return value to reconstruct the nested tuple structure: @out tuple returns are not flattened, unlike regular tuple returns.
Specify the operand ownership of the Builtin differently depending on whether lowered addresses are used. Handle rewriting the value version of the builtin as the address version of the builtin in AddressLowering.
The variants are produced by SILGen when opaque values are enabled. They are necessary because otherwise SILGen would produce address_to_pointer of values. They will be lowered by AddressLowering.
Now that generic values have been lowered to addresses, create the address_to_pointer instructions.
Only create alloc_stacks for address-only tuple returns when using lowered addresses.
|
@swift-ci please test |
atrick
reviewed
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only create alloc_stacks for address-only tuple returns when using lowered addresses.
Based on #61887 .