[stdlib] String.Index: Add _description & _debugDescription #61548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we’re vacillating on how best to add CustomStringConvertible and CustomDebugStringConvertible conformances to String.Index, add the prospective implementations as underscored-but-public members, to make life a little more bearable for people who need to debug string index operations.
|
@swift-ci test |
|
@swift-ci test macOS platform |
|
@swift-ci smoke test macOS platform |
|
@swift-ci please smoke test macOS |
|
@swift-ci smoke test macOS platform |
|
@swift-ci please test macOS |
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 28, 2022
Implement a type summary for Swift's `String.Index`. The summary string follows the following: 1. Original proposal: https://forums.swift.org/t/improving-string-index-s-printed-descriptions/57027 2. Proposed implementation: swiftlang/swift#58479 3. Temporary(ish) near-`CustomStringConvertible` implementation: swiftlang/swift#61548 The associated test cases are taken from the test cases in swiftlang/swift#58479. rdar://99211823
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Nov 2, 2022
Implement a type summary for Swift's `String.Index`. The summary string follows the following: 1. Original proposal: https://forums.swift.org/t/improving-string-index-s-printed-descriptions/57027 2. Proposed implementation: swiftlang/swift#58479 3. Temporary(ish) near-`CustomStringConvertible` implementation: swiftlang/swift#61548 The associated test cases are taken from the test cases in swiftlang/swift#58479. rdar://99211823 (cherry picked from commit c7146a3)
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 9, 2023
Implement a type summary for Swift's `String.Index`. The summary string follows the following: 1. Original proposal: https://forums.swift.org/t/improving-string-index-s-printed-descriptions/57027 2. Proposed implementation: swiftlang/swift#58479 3. Temporary(ish) near-`CustomStringConvertible` implementation: swiftlang/swift#61548 The associated test cases are taken from the test cases in swiftlang/swift#58479. rdar://99211823 (cherry picked from commit c7146a3)
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 9, 2023
Implement a type summary for Swift's `String.Index`. The summary string follows the following: 1. Original proposal: https://forums.swift.org/t/improving-string-index-s-printed-descriptions/57027 2. Proposed implementation: swiftlang/swift#58479 3. Temporary(ish) near-`CustomStringConvertible` implementation: swiftlang/swift#61548 The associated test cases are taken from the test cases in swiftlang/swift#58479. rdar://99211823 (cherry picked from commit c7146a3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we’re vacillating on how best to add CustomStringConvertible and CustomDebugStringConvertible conformances to String.Index, add the prospective implementations as underscored-but-public members, to make life a little more bearable for people who need to debug string index operations.