[CSRanking] Adjust ranking of makeIterator overloads in for-in context
#61075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
…ntext
Prefer an overload of `makeIterator` that satisfies
`Sequence#makeIterator` requirement when `.makeIterator()`
is implicitly injected after sequence expression in `for-in`
loop context.
This helps to avoid issues related to conditional conformances
to `Sequence` that add `makeIterator` preferred by overloading
rules that could change behavior i.e.:
```swift
extension Array where Element == Double {
func makeIterator() -> Array<Int>.Iterator {
return [1, 2, 3].makeIterator()
}
}
for i in [4.0, 5.0, 6.0] {
print(i)
}
```
`makeIterator` declared in the `Array` extension is not a witness
to `Sequence#makeIterator` and shouldn't be used because that would
change runtime behavior.
Resolves: swiftlang#60514
Resolves: swiftlang#60958
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@AnthonyLatsis Sure, let's let the source compat run and I'm going to rename before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer an overload of
makeIteratorthat satisfiesSequence#makeIteratorrequirement when.makeIterator()is implicitly injected after sequence expression in
for-inloop context.
This helps to avoid issues related to conditional conformances
to
Sequencethat addmakeIteratorpreferred by overloadingrules that could change behavior i.e.:
makeIteratordeclared in theArrayextension is not a witness toSequence#makeIteratorand shouldn't be used because that would change runtime behavior.Resolves: #60514
Resolves: #60958