[cxx-interop] Add CxxShim library; move __swift_interopStaticCast into it.
#59754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
commented
Jun 28, 2022
| ctx.getClangModuleLoader()->getWrapperForModule(owningModule); | ||
| // Lookup our static cast helper function in the C++ shim module. | ||
| auto wrapperModule = ctx.getLoadedModule(ctx.getIdentifier("CxxShim")); | ||
| assert(wrapperModule && |
There was a problem hiding this comment.
I'll make this a diagnostic in a follow-up patch.
zoecarver
force-pushed
the
fix-static-down-cast-shim
branch
from
30a9353 to
bbc2007
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test macOS |
egorzhdan
reviewed
Jun 29, 2022
egorzhdan
reviewed
Jun 29, 2022
|
@swift-ci please test Windows |
zoecarver
force-pushed
the
fix-static-down-cast-shim
branch
2 times, most recently
from
f21f821 to
800bd74
Compare
|
@swift-ci please test |
egorzhdan
reviewed
Jul 1, 2022
| @@ -0,0 +1 @@ | |||
| @_exported import CxxShim // Clang module | |||
There was a problem hiding this comment.
This file is not used anymore, it can be removed.
|
@swift-ci please test windows |
zoecarver
force-pushed
the
fix-static-down-cast-shim
branch
from
800bd74 to
273065e
Compare
|
@swift-ci please test |
zoecarver
force-pushed
the
fix-static-down-cast-shim
branch
from
273065e to
8cf4d3b
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.