[Threading] Fix 32-bit Linux. #59371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`swift::once` needs to be 32-bit on 32-bit Linux, which means we have to revert to using a global lock. rdar://94831034
|
@swift-ci Please smoke test |
mikeash
approved these changes
Jun 10, 2022
drodriguez
approved these changes
Jun 10, 2022
|
I don't think the Linux error is really related (but I might be wrong). |
|
@swift-ci please smoke test Linux platform |
|
No, agreed, the Linux error isn't anything to do with this. (Thanks for re-triggering the smoke test.) |
|
Happy to report this appears to have fixed the issue on the 32-bit Android armv7 CI, thanks for the quick turnaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift::onceneeds to be 32-bit on 32-bit Linux, which means we have to revert to using a global lock in that case.rdar://94831034