Skip to content

Revert "Revert "[cxx-interop][SwiftCompilerSources] Fix conversion between std::string and Swift.String"" #59353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

egorzhdan
Copy link
Contributor

This reverts commit 9542837.

The assertion failure has been fixed in #59345.

…tween `std::string` and `Swift.String`""

This reverts commit 9542837.
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jun 9, 2022
@egorzhdan egorzhdan requested a review from eeckstein June 9, 2022 23:43
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@egorzhdan egorzhdan merged commit d00c0f5 into main Jun 10, 2022
@egorzhdan egorzhdan deleted the egorzhdan/reland-libswift-string-init branch June 10, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants