[cxx-interop][SwiftCompilerSources] Fix conversion between std::string and Swift.String
#59152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
force-pushed
the
egorzhdan/libswift-string-init
branch
2 times, most recently
from
3d27915 to
c570984
Compare
|
@swift-ci please smoke test |
eeckstein
approved these changes
May 30, 2022
| /// Underscored to avoid name collision with the std overlay. | ||
| /// To be replaced with an overlay call once the CI uses SDKs built with Swift 5.7. | ||
| public init(_cxxString s: std.string) { | ||
| self.init(cString: s.c_str()) |
There was a problem hiding this comment.
Is it not required anymore that s is a var for calling c_str? (I can't remember why we had to do this).
There was a problem hiding this comment.
We were using var to avoid breaking the hosttools build for people using Xcode 13.2 or older. Now that Xcode 13.4 is released, this is probably no longer necessary.
We could produce a friendly CMake error for an outdated Swift compiler version if we merge #59020.
…ng` and `Swift.String`
This fixes a dangling pointer issue when creating a `Swift.String` from `std::string`.
Also fixes a warning:
```
warning: variable 's' was never mutated; consider changing to 'let' constant
var s = SILBasicBlock_debugDescription(bridged)
~~~ ^
let
```
rdar://92963081
rdar://93053488
egorzhdan
force-pushed
the
egorzhdan/libswift-string-init
branch
from
c570984 to
be711e3
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a dangling pointer issue when creating a
Swift.Stringfromstd::string.Also fixes a warning:
rdar://92963081
rdar://93053488