[Serialization] Harden the compiler tag check on swiftmodules #58880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When two different serialization formats share a version number but are different enough, it can defeat the check to restrict loading swiftmodules built by the same compiler. Add a backup check in case the REVISION block is unseen, for swiftmodules only not swiftdoc or sourceinfo. rdar://93188070
|
@swift-ci Please smoke test |
bnbarham
approved these changes
May 12, 2022
| if (requiresRevisionMatch && | ||
| !revisionSeen && | ||
| result.status == Status::Valid) | ||
| result.status = Status::RevisionIncompatible; |
There was a problem hiding this comment.
Should it just be Status::Malformed in that case? Ie. the same as the missing version case?
There was a problem hiding this comment.
It could be, but I like having a different code for it. I would expect to see Malformed if the header is missing/truncated, while RevisionIncompatible remains a case where the format is mostly fine but it was definitively written by a different compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two different serialization formats share a version number but are different enough, it can defeat the check to restrict loading swiftmodules built by the same compiler. Add a backup check in case the
REVISIONblock is not seen to detect such issues. This applies to swiftmodules only and not to swiftdoc or sourceinfo files.rdar://93188070