Skip to content

[Distributed] Diagnose missing inout on remoteCall decls #58672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2022
Merged

[Distributed] Diagnose missing inout on remoteCall decls #58672

merged 1 commit into from
May 5, 2022

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 4, 2022

Resolves #58671
Resolves rdar://92754877

@ktoso
Copy link
Contributor Author

ktoso commented May 4, 2022

@swift-ci please smoke test

@ktoso ktoso mentioned this pull request May 4, 2022
Open
@ktoso
Copy link
Contributor Author

ktoso commented May 4, 2022

Unrelated CI crash


fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2671)

@ktoso
Copy link
Contributor Author

ktoso commented May 4, 2022

@swift-ci please smoke test

@ktoso ktoso added the distributed Feature → concurrency: distributed actor label May 4, 2022
@ktoso
Copy link
Contributor Author

ktoso commented May 5, 2022

@swift-ci please smoke test linux

@ktoso
Copy link
Contributor Author

ktoso commented May 5, 2022

@swift-ci please smoke test linux
@swift-ci please smoke test macos

@shahmishal
Copy link
Member

@swift-ci please smoke test linux

@ktoso ktoso merged commit ff211b7 into swiftlang:main May 5, 2022
@ktoso ktoso mentioned this pull request May 5, 2022
Merged
@ktoso ktoso deleted the wip-missing-inout-diagnose branch May 5, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Distributed] missing diagnosis for missing inout on remoteCall params
3 participants
@ktoso @shahmishal @xedin