Skip to content

IRGen: import external vtable symbols always as _public_ undefined sy… #4927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

eeckstein
Copy link
Contributor

…mbols and not as local undefined symbols.

This doesn't make a difference on Darwin, but on Linux it causes linker errors if a class inherits from a public class in another module which has private/internal members.

fixes SR-1901

@eeckstein
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@jrose-apple
Copy link
Contributor

This is still incorrect behavior, though, right? We actually do need those symbols in the subclass's vtable.

…mbols and not as _local_ undefined symbols.

This doesn't make a difference on Darwin, but on Linux it causes linker errors if a class inherits from a public class in another module which has private/internal members.

fixes SR-1901
@eeckstein
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@jrose-apple
Copy link
Contributor

Erik explained what was going on here; I had just misunderstood.

@eeckstein
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 1f46c56 into swiftlang:master Sep 23, 2016
@eeckstein eeckstein deleted the fix-linkage branch September 23, 2016 00:17
MaxDesiatov pushed a commit that referenced this pull request Sep 7, 2023
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants