Skip to content

[Preset] Add libdispatch in Linux presets #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shahmishal
Copy link
Member

What's in this pull request?

Now swift PR and Package CI jobs will require libdispatch repository to build on Linux.

Resolved bug number: (N/A)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@shahmishal
Copy link
Member Author

@swift-ci Please test

@shahmishal
Copy link
Member Author

00:30:00 ====================================================
00:30:00 Testsuite summary for libdispatch 1.3
00:30:00 =============================================
00:30:00 # TOTAL: 26
00:30:00 # PASS: 25
00:30:00 # SKIP: 0
00:30:00 # XFAIL: 0
00:30:00 # FAIL: 1
00:30:00 # XPASS: 0
00:30:00 # ERROR: 0

@RLovelett
Copy link
Contributor

Does this supercede #4203?

@RLovelett
Copy link
Contributor

RLovelett commented Aug 16, 2016

@shahmishal this failing test looks to be the same one that I was experiencing locally.

Do these tests run as root? If so that is likely the problem.

@RLovelett
Copy link
Contributor

RLovelett commented Aug 16, 2016

Also I'd point out that I think even if you got the current failure resolved the package validation tests would fail. Or at least that is the case when I am building locally. In order to resolve those you need #3835.

@shahmishal
Copy link
Member Author

This is duplication of #4203, closing this PR.

@shahmishal shahmishal closed this Aug 16, 2016
@jrose-apple jrose-apple deleted the add-libdispatch-in-pr-and-package branch August 17, 2016 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants