Skip to content

[shims] Remove the _SwiftDispatchOverlayShims module #41274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Feb 8, 2022

This module used to be a private implementation detail of the Dispatch overlay on Apple platforms, and swift-corelibs-libdispatch elsewhere.

Darwin hasn't been using this module for a couple years now, and swift-corelibs-dispatch stopped using it with swiftlang/swift-corelibs-libdispatch#592. We are now free to remove it from the Swift toolchain -- which is good, as it contains declarations that are specific to Dispatch, and the compiler/stdlib is not the right place to maintain them.

This module used to be a private implementation detail of the Distpatch overlay on Apple platforms, and swift-corelibs-libdispatch elsewhere.

Darwin hasn't been using this module for a couple years now, and swift-corelibs-dispatch stopped using it with swiftlang/swift-corelibs-libdispatch#592. We are now free to remove it from the Swift toolchain -- which is good, as it contains declarations that are specific to Dispatch, and the compiler/stdlib is not the right place to maintain them.
@lorentey lorentey requested a review from Azoy February 8, 2022 19:39
@lorentey
Copy link
Member Author

lorentey commented Feb 8, 2022

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 9, 2022

Build failed
Swift Test OS X Platform
Git Sha - 4e90871

@lorentey
Copy link
Member Author

lorentey commented Feb 9, 2022

16:59:02 
java.io.EOFException
16:59:02 	at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2798)
16:59:02 	at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3273)
16:59:02 	at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:933)
16:59:02 	at java.io.ObjectInputStream.<init>(ObjectInputStream.java:395)
16:59:02 	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:49)
16:59:02 	at hudson.remoting.Command.readFrom(Command.java:142)
16:59:02 	at hudson.remoting.Command.readFrom(Command.java:128)
16:59:02 	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35)
16:59:02 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:61)
16:59:02 Caused: java.io.IOException: Unexpected termination of the channel
16:59:02 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:75)
16:59:02 Caused: java.io.IOException: Backing channel 'macOS-55' is disconnected.

@lorentey
Copy link
Member Author

lorentey commented Feb 9, 2022

@swift-ci test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Feb 9, 2022

Build failed
Swift Test OS X Platform
Git Sha - 4e90871

@lorentey
Copy link
Member Author

lorentey commented Feb 9, 2022

Ah, this is unrelated & will be fixed by #41298:

<unknown>:0: warning: using sysroot for 'iPhoneSimulator' but targeting 'MacOSX'
<unknown>:0: warning: using sysroot for 'iPhoneSimulator' but targeting 'MacOSX'
<unknown>:0: warning: module interfaces are only supported with Swift language version 5 or later (currently using -swift-version 4)
<unknown>:0: error: module 'Test' was created for incompatible target x86_64-apple-macosx11.0: /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/buildbot_incremental/swift-macosx-x86_64/test-iphonesimulator-x86_64/ModuleInterface/Output/back-deploy-attr.swift.tmp/Test.swiftmodule

@lorentey
Copy link
Member Author

lorentey commented Feb 9, 2022

@swift-ci smoke test macOS platform

@lorentey lorentey merged commit b20f015 into swiftlang:main Feb 9, 2022
@lorentey lorentey deleted the remove-Dispatch-shims branch February 9, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants