Determine concurrency diagnostic behavior based on conformance context. #41078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining whether to warn, error, or be silent about concurrency-related issues detected between a protocol requirement and its witness, decide based on the context of the conformance rather than based on the context of the witness. Fixes rdar://88205585.
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please nominate |
tbkka
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: When determining whether to warn, error, or be silent about concurrency-related issues detected between a protocol requirement and its witness, decide based on the context of the conformance rather than based on the context of the witness.
Scope: Manifests as extraneous warnings in SwiftUI apps that introduce conformances to
UIViewRepresentable.Radar/SR Issue: rdar://88205585
Risk: Low.
Testing: PR testing and CI .
Reviewed By: John McCall
Original PR: #41076