Skip to content

[RemoteMirror] Get spare bit info from reflection records #40906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Feb 22, 2022
Merged

[RemoteMirror] Get spare bit info from reflection records #40906

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
1e34a91
Initialize FieldInfo
tbkka Dec 8, 2021
2afe9b5
Expanded tests for MPEs
tbkka Dec 8, 2021
5c583eb
Restore fallback calculation of MPE spare bit mask
tbkka Dec 8, 2021
b07c084
Add MPE flag bits to the BuiltinTypeDescriptor
tbkka Dec 8, 2021
3039ec8
Store MPE layout in a new MultiPayloadEnumDescriptor reflection record
tbkka Dec 23, 2021
230387e
Typo
tbkka Jan 27, 2022
caa6787
Use memset
tbkka Jan 27, 2022
67220d0
Make `andMask` consistent with usage
tbkka Jan 27, 2022
63d1f47
Do not break old, deprecated API
tbkka Jan 27, 2022
77b5b1e
Some debugging utilities
tbkka Jan 28, 2022
6e25fd8
Use a helper to produce the right type info
tbkka Jan 28, 2022
e76c049
Be a little smarter about choosing a spare bit mask for pointers
tbkka Jan 28, 2022
70c08a0
Get the correct spare bit info from the type system
tbkka Jan 28, 2022
8b30c35
Use the correct spare bits mask; allow MPE record to grow in the future
tbkka Feb 1, 2022
05d2110
Minor code simplification
tbkka Feb 2, 2022
d3b75ad
Assert in the runtime that MPE reflection records are sane
tbkka Feb 2, 2022
0856692
Do not break legacy API
tbkka Feb 2, 2022
8f1ec22
Update comment; remove unnecessary code
tbkka Feb 2, 2022
3553665
Simply dump routine
tbkka Feb 2, 2022
1a4a9e4
Reduce the size of the reflection record
tbkka Feb 2, 2022
c41247e
Consolidate the two copies of getFormalTypeInContext()
tbkka Feb 2, 2022
9d368ce
Expand the failure messages here to help track down a bug
tbkka Feb 3, 2022
d467401
Missing include
tbkka Feb 3, 2022
e9fb6e5
More detail on this crash
tbkka Feb 3, 2022
21f82c8
More detail on this crash
tbkka Feb 3, 2022
5e3985d
Log the bytes and the type of data in the section
tbkka Feb 3, 2022
609fa7e
print numbers, not characters
tbkka Feb 4, 2022
27161d8
Clarify a comment
tbkka Feb 4, 2022
f256c03
Rename some variables for legibility
tbkka Feb 5, 2022
86d25f0
Try to make the index offsets easier to follow
tbkka Feb 5, 2022
3cd9146
Clean up the debug logging here a little bit
tbkka Feb 5, 2022
1603c6a
Add the new reflection section to the COFF and ELF declarations; decl…
tbkka Feb 5, 2022
b5d31d0
Expose MPE Spare bit mask as a global var in target, fetch from host
tbkka Feb 9, 2022
fe070c8
Merge branch 'main' into tbkka-remoteMirror-MPE-spareBits-v2
tbkka Feb 10, 2022
45d993d
Fix a merge conflict with the accessibility function section that's a…
tbkka Feb 10, 2022
32d3dc7
Merge branch 'main' into tbkka-remoteMirror-MPE-spareBits-v2
tbkka Feb 11, 2022
a87ed0c
Merge branch 'main' into tbkka-remoteMirror-MPE-spareBits-v2
tbkka Feb 11, 2022
01111fc
Enable debug assertions whenever !NDEBUG
tbkka Feb 16, 2022
673e3a0
Merge branch 'tbkka-remoteMirror-MPE-spareBits-v2' of github.com:tbkk…
tbkka Feb 16, 2022
72e3d54
New MPE test inspired by an LLDB test case
tbkka Feb 18, 2022
70dae3d
Disable mask computation for types containing enums
tbkka Feb 18, 2022
c470f7c
Merge remote-tracking branch 'github-apple/main' into tbkka-remoteMir…
tbkka Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable debug assertions whenever !NDEBUG
  • Loading branch information
@tbkka
tbkka committed Feb 16, 2022
commit 01111fc7041a3eed1fa38714656ab972fa86cf9e
5 changes: 3 additions & 2 deletions stdlib/public/Reflection/TypeLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2026,8 +2026,9 @@ class EnumTypeInfoBuilder {
PayloadSpareBitMaskByteCount, PayloadSpareBitMaskByteOffset);

if (!spareBitsMask.isZero()) {
#if !defined(NDEBUG) && 0
// DEBUGGING: compare the locally-computed spare bit mask to the

#if !defined(NDEBUG)
// DEBUG ASSERTION: compare the locally-computed spare bit mask to the
// one we got from the compiler. If they're different, then
// either the compiler is emitting the wrong thing or the
// local runtime computation isn't quite right.
Expand Down