Skip to content

[SymbolGraphGen] don't emit access control attributes in declarations #40696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

QuietMisdreavus
Copy link
Contributor

In "emit module separately" jobs, access control modifiers appear as attributes as well as in the declaration itself. Declarations in the symbol graph don't want to emit access-level keywords in declarations, so this PR turns those off.

Resolves rdar://85280786

@QuietMisdreavus
Copy link
Contributor Author

I added the test the way i did so that i could investigate rdar://85230067 at the same time, which was another issue about modules appearing differently to SymbolGraphGen in "emit modules separately" mode. I'd like to extend it in a future PR with the fix to that issue.

@swift-ci Please smoke test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants