[5.6 CMake] Move most Standard Library options in a separate file #40669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the file to be easily included where needed (e.g. `StandaloneOverlay.cmake`) and reduce the likelihood of miscompilation due to missing sensible defaults. Focus on parameters only in stdlib/CMakeLists.txt whose defaults are not computed. This matches swiftlang#40610 + swiftlang#40640 Addresses rdar://86740965
|
@swift-ci please test Apple Silicon |
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
gottesmm
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the file to be easily included where needed (e.g.
StandaloneOverlay.cmake) and reduce the likelihood of miscompilationdue to missing sensible defaults.
Focus on parameters only in stdlib/CMakeLists.txt whose defaults are not
computed.
This matches #40610 + #40640
Addresses rdar://86740965