[AllocStackHoisting] New dealloc_stack's locs are cleanups. #40516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllocStackHoisting creates new dealloc_stack instructions. The old
dealloc_stack instructions' locations' kinds are ::CleanupKind The new
instructions' locations need to be of that same kind too in order not to
trigger the sil verifier failure
Basic block contains a non-contiguous lexical scope at -Onone
when building at Onone.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test linux platform |
nate-chandler
deleted the
alloc_stack_hoisting/make-new-dealloc_stacks-locs-cleanups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AllocStackHoisting creates new dealloc_stack instructions. The old dealloc_stack instructions' locations' kinds are ::CleanupKind The new instructions' locations need to be of that same kind too in order not to trigger the sil verifier failure
when building at Onone.