[CMake] Add SWIFT_STDLIB_SHORT_MANGLING_LOOKUPS to StandaloneOverlay #40311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow it to have a sensible default when e.g. building the back deploy concurrency library. Addresses rdar://85815655
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci please smoke test |
|
macOS Toolchain Install command |
kubamracek
approved these changes
Nov 30, 2021
|
As an immediate fix, LGTM. Though we should really find a way to avoid this from happening in the future, either enforce StandaloneOverlay.cmake and stdlib/CMakeLists.txt being in sync, or including one from the other or something like that. |
|
Working on proper long term fix in #40610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow it to have a sensible default in configurations that use it.
Addresses rdar://85815655