SR-15237 Fix typelayout_based_value_witness.swift #39419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typelayout_based_value_witness.swift failed on iphoneos-arm64e due to an extra line of IR that gets generated. That meant the swift_release line had 'swiftlang#7' instead of 'swiftlang#6'. The test shouldn't be checking for 'swiftlang#6' anyways, so removed that check which causes the test to now pass.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typelayout_based_value_witness.swift failed on iphoneos-arm64e due to an extra
line of IR that gets generated. That meant the swift_release line had '#7'
instead of '#6'. The test shouldn't be checking for '#6' anyways, so removed
that check which causes the test to now pass.
Resolves part of https://bugs.swift.org/browse/SR-15237